Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customer save handlers should support DI #205

Open
markus-moser opened this issue Apr 13, 2021 · 1 comment
Open

Customer save handlers should support DI #205

markus-moser opened this issue Apr 13, 2021 · 1 comment
Labels
Improvement PR Welcome

Comments

@markus-moser
Copy link
Contributor

As they are migrated from Pimcore 4 they are currently not implemented as services.
@dvesh3 dvesh3 added this to the v4.0.0 milestone Oct 17, 2022
@dvesh3 dvesh3 self-assigned this Dec 27, 2022
dvesh3 added a commit that referenced this issue Dec 27, 2022
@dvesh3
Use DI for services & remove aliases - resolves #205
c32f673
@dvesh3 dvesh3 mentioned this issue Dec 27, 2022
Closed
2 tasks
dvesh3 added a commit that referenced this issue Dec 28, 2022
@dvesh3
Use DI for services & remove aliases - resolves #205
dcd0fbe
dvesh3 added a commit that referenced this issue Dec 28, 2022
@dvesh3
Use DI for services & remove aliases - resolves #205
b660b20
dvesh3 added a commit that referenced this issue Dec 28, 2022
@dvesh3
Use DI for services & remove aliases - resolves #205
99d3297
dvesh3 added a commit that referenced this issue Dec 28, 2022
@dvesh3
Use DI for services & remove aliases - resolves #205
8c08a9c
dvesh3 added a commit that referenced this issue Dec 28, 2022
@dvesh3
Use DI for services & remove aliases - resolves #205
ca2e1c8
dvesh3 added a commit that referenced this issue Jan 2, 2023
@dvesh3
Use DI for services & remove aliases - resolves #205
a7c5e59
@dvesh3 dvesh3 removed this from the v4.0.0 milestone Apr 11, 2023
@github-actions GitHub Actions
Copy link

Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement PR Welcome
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use DI for services & remove aliases pimcore/customer-data-framework
2 participants
@markus-moser @dvesh3