[Admin] Backend view - duplicate search result on filtered list #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dvesh3
reviewed
May 3, 2022
src/CustomerList/SearchHelper.php
Outdated
| @@ -138,6 +138,7 @@ public function addListingFilters(Concrete $listing, array $filters, User $admin | |||
| $segments[] = $segment; | |||
| } | |||
| } | |||
| $handler->getListing()->setGroupBy('o_id', true); | |||
There was a problem hiding this comment.
How about we set groupBy in CustomerController:buildListing()? as this will also used by export/download.
dvesh3
force-pushed
the
customer_duplicate_search_fix
branch
from
d1af0b8
to
6fc9bd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #275