Removed o_ prefixes
#379
Closed
Removed o_ prefixes
#379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aashan10
commented
Dec 5, 2022
aashan10
commented
Dec 5, 2022
| @@ -5,7 +5,7 @@ | |||
| <th class="table-id-column">#</th> | |||
| <th width="80px"> | |||
| <div class="pos"> | |||
| <a class="sorting{{ cmf_currentOrder('o_id') }}" href="{{ path('customermanagementframework_admin_customers_list', cmf_nextFormOrderParams('o_id')) }}"> | |||
| <a class="sorting{{ cmf_currentOrder('id') }}" href="{{ path('customermanagementframework_admin_customers_list', cmf_nextFormOrderParams('id')) }}"> | |||
There was a problem hiding this comment.
@dvesh3 @mcop1 also on twig files same thing as https://github.com/pimcore/customer-data-framework/pull/379/files#r1039488239
There was a problem hiding this comment.
we should pass this variable (with value from getVersionDependentDatabaseColumnName) from list action and read it here..
aashan10
commented
Dec 5, 2022
| SELECT `breaksInheritance` FROM `plugin_cmf_segment_assignment` WHERE `elementId` = elementIdent AND `elementType` = 'object' INTO breaks; | ||
|
|
||
| WHILE (elementExists = 0 OR breaks IS NULL OR breaks <> 1) AND elementIdent > 1 DO | ||
| SELECT `parentId` FROM `objects` WHERE `id` = elementIdent INTO elementIdent; |
There was a problem hiding this comment.
@dvesh3 what about here?
There was a problem hiding this comment.
I think we have to check column here and run command specifically. please see suggestions here https://stackoverflow.com/questions/133031/how-to-check-if-a-column-exists-in-a-sql-server-table
There was a problem hiding this comment.
not sure though if this is the best solution
|
dvesh3
reviewed
Dec 15, 2022
dvesh3
reviewed
Dec 15, 2022
|
Closed in favor of #382 |
dvesh3
added a commit
that referenced
this pull request
Dec 15, 2022
* Changes for #379 * Changes for #379 * Removde o_ prefix Signed-off-by: dvesh3 <divesh.pahuja@pimcore.com> * Removde o_ prefix Signed-off-by: dvesh3 <divesh.pahuja@pimcore.com> * Removde o_ prefix Signed-off-by: dvesh3 <divesh.pahuja@pimcore.com> Signed-off-by: dvesh3 <divesh.pahuja@pimcore.com> Co-authored-by: Ashan Ghimire <ashanghimire10@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #342