Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Fixed JS namespace error #425

Closed
wants to merge 1 commit into from
Closed

[Bug] Fixed JS namespace error #425

wants to merge 1 commit into from

Conversation

Corepex
Copy link
Contributor

@Corepex Corepex commented Feb 28, 2023

It should be enough to test if pimcore.report exists since the new namespace starts with pimcore.bundle ....

image

@Corepex Corepex added the Bug label Feb 28, 2023
@Corepex Corepex added this to the v4.0.0 milestone Feb 28, 2023
@blankse
Copy link
Contributor

blankse commented Feb 28, 2023

@Corepex You removed Pimcore 10 support. So we can remove it, right? See my PR: #424

@Corepex
Copy link
Contributor Author

Corepex commented Mar 1, 2023 •
edited
Loading

@Corepex You removed Pimcore 10 support. So we can remove it, right? See my PR: #424

right, I just saw that CMF (4.x) only supports pimcore 11.x so this should be obsolete yes

@Corepex Corepex self-assigned this Mar 1, 2023
@Corepex
Copy link
Contributor Author

Corepex commented Mar 1, 2023

closed due to duplication #424

@Corepex Corepex closed this Mar 1, 2023
@Corepex Corepex deleted the fix-js-namespace-error branch March 1, 2023 11:23
@fashxp fashxp removed this from the v4.0.0 milestone Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Corepex Corepex

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Corepex @blankse @fashxp