Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Fix Inheritable Segment query #460

Merged
merged 5 commits into from May 16, 2023
Merged

[Bug]: Fix Inheritable Segment query #460

merged 5 commits into from May 16, 2023

Conversation

kingjia90
Copy link
Contributor

@kingjia90 kingjia90 commented May 3, 2023 •
edited

This type empty string fallback doesn't make sense because the queru would be SELECT * FROM s (suffixed substring)

@kingjia90 kingjia90 added the Bug label May 3, 2023
@kingjia90 kingjia90 marked this pull request as draft May 3, 2023 11:59
@kingjia90 kingjia90 marked this pull request as ready for review May 3, 2023 12:25
@dvesh3 dvesh3 merged commit 76df151 into 3.3 May 16, 2023
5 checks passed
@dvesh3 dvesh3 added this to the v3.3.10 milestone May 16, 2023
@dvesh3 dvesh3 deleted the inheritable-segments branch May 16, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvesh3 dvesh3 dvesh3 left review comments

Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
v3.3.10
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kingjia90 @dvesh3