Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added null check to confirm (new) customer objects have an id before use. #518

Closed
wants to merge 11 commits into from
Closed

Added null check to confirm (new) customer objects have an id before use. #518

wants to merge 11 commits into from

Conversation

keifphos
Copy link
Contributor

Added null check to confirm (new) customer objects have an id before attempting to use the id as per #517

@CLAassistant
Copy link

CLAassistant commented Nov 23, 2023

CLA assistant check
All committers have signed the CLA.

@keifphos keifphos changed the title Added null check to confirm (new) customer objects have an id before use. #517 Added null check to confirm (new) customer objects have an id before use. Nov 23, 2023
@dvesh3 dvesh3 added the Bug label Nov 24, 2023
@robertSt7
Copy link
Contributor

Hi @keifphos since this is a bug fix could you please rebase the PR to 4.0? Thanks

@keifphos keifphos changed the base branch from 4.x to 4.0 December 12, 2023 17:55
@keifphos
Copy link
Contributor Author

Hey @robertSt7 no worries that is done, thanks.

@robertSt7
Copy link
Contributor

@keifphos There are still other commits besides yours in the PR. Could you please drop these commits and force push or open a new PR with 4.0 as base? Thank you

@keifphos
Copy link
Contributor Author

@robertSt7 my bad, i'll close this and make a new PR.

@keifphos keifphos closed this Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants