Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.3 Support #529

Merged
merged 4 commits into from
Jun 18, 2024
Merged

PHP 8.3 Support #529

merged 4 commits into from
Jun 18, 2024

Conversation

blankse
Copy link
Contributor

@blankse blankse commented Feb 29, 2024

@limenet
Copy link

limenet commented Apr 18, 2024

@blankse since pimcore/personalization-bundle#66 and pimcore/pimcore#16589 are merged, what's needed to get this merged as well?

@blankse
Copy link
Contributor Author

blankse commented Apr 18, 2024

@limenet The 1.1.0 release in pimcore/personalization-bundle, because the tests only loads releases.

@fashxp fashxp added this to the 4.1.0 milestone Jun 11, 2024
@kingjia90
Copy link
Contributor

@blankse could you please temporary change to require the 1.x-dev branch of personalization bundle to let the test run again?
I am confident that it would be green but just to be sure 😄 Then i will just merge this, i am then also proceeding on merging pimcore/demo#568 which led me here

@kingjia90 kingjia90 self-assigned this Jun 11, 2024
@blankse
Copy link
Contributor Author

blankse commented Jun 11, 2024

@kingjia90 This is not enough for the demo repository. You also need pimcore/ecommerce-framework-bundle#164 pimcore/data-hub#840

@kingjia90
Copy link
Contributor

kingjia90 commented Jun 11, 2024

Ahh right, then it's worth to merge and test near the minor releases day otherwise the master branch would be still reporting false negative tests, it shouldn't take that much time by then, thank you anyways

@fashxp fashxp changed the base branch from 4.x to 4.0 June 11, 2024 20:01
@fashxp fashxp changed the base branch from 4.0 to 4.x June 11, 2024 20:01
@fashxp fashxp self-assigned this Jun 12, 2024
@fashxp
Copy link
Member

fashxp commented Jun 18, 2024

@blankse you are simply too fast ;-)
thx for fixing.

@fashxp fashxp merged commit 14f7426 into pimcore:4.x Jun 18, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 18, 2024
@blankse blankse deleted the php_8_3 branch June 18, 2024 08:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants