Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Configuration] Add more fine-grained permissions to configurations #122

Merged
merged 40 commits into from
Jan 5, 2022

Conversation

dvesh3
Copy link
Contributor

@dvesh3 dvesh3 commented Nov 12, 2021

@fashxp
Copy link
Member

fashxp commented Nov 29, 2021

probably add a migration that re-installs the bundle ... so that already installed bundles don't need to be installed again?

@dvesh3
Copy link
Contributor Author

dvesh3 commented Nov 29, 2021

probably add a migration that re-installs the bundle ... so that already installed bundles don't need to be installed again?

@fashxp yes, should be handled here as the migration returns true for checkBundleInstalled

@fashxp
Copy link
Member

fashxp commented Nov 29, 2021

ahh, oversaw that, perfect 👍

@fashxp fashxp added this to the v1.4.0 milestone Dec 1, 2021
@flamadrid-jsmdg flamadrid-jsmdg mentioned this pull request Dec 14, 2021
5 tasks
composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
@mcop1 mcop1 requested a review from fashxp December 29, 2021 10:46
dvesh3 and others added 19 commits December 30, 2021 15:12
Co-authored-by: Sebastian Blank <blank@data-factory.net>
…ine_grained_permissions

# Conflicts:
#	src/Resources/public/js/pimcore/configuration/configItemDataObject.js
@mcop1 mcop1 requested a review from fashxp January 4, 2022 09:51
@fashxp fashxp merged commit 6569c18 into 1.x Jan 5, 2022
@fashxp fashxp deleted the fine_grained_permissions branch January 5, 2022 09:51
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants