Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Content Security Policy header based on new handler #300

Closed
dvesh3 opened this issue Mar 14, 2022 · 2 comments · Fixed by #303
Closed

Setup Content Security Policy header based on new handler #300

dvesh3 opened this issue Mar 14, 2022 · 2 comments · Fixed by #303
Assignees
Labels

Comments

@dvesh3
Copy link
Contributor

dvesh3 commented Mar 14, 2022

Feature description

Based on pimcore/pimcore#11447

Also add configuration to whitelist urls:

# config/config.yaml
pimcore_admin:
    admin_csp_header:
        additional_urls:
            script_src:
                - 'http://unpkg.com/axios/dist/'
                - 'http://unpkg.com/react/umd/'
                - 'http://unpkg.com/react-dom/umd/'
            style-src:
                - 'https://cdn.jsdelivr.net/npm/'
@aryaantony92
Copy link
Contributor

The urls "//unpkg.com/axios/dist/", "//unpkg.com/react/umd/" and "//unpkg.com/react-dom/umd/" should be white listed inside the core bundle. And the "cdn.jsdelivr.net/npm/" is already whitelisted in the admin side.

@fashxp fashxp reopened this Mar 28, 2022
@fashxp
Copy link
Member

fashxp commented Mar 28, 2022

TODO:

  • create PR that enables the config
  • bump minimum requirement for pimcore to ^10.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants