[Task]: Verfiy identifyer quoting for sql queries #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingjia90
force-pushed
the
fix_column_identifier
branch
from
6704140
to
ff62fb0
Compare
mattamon
reviewed
Jan 16, 2023
| @@ -33,7 +33,7 @@ public function load() | |||
|
|
|||
| $params = array_column($this->model->getConditionParams() ?: [], 'value'); | |||
|
|
|||
| $unitIds = $this->db->fetchAll('SELECT o_id, id, o_classId, channel FROM ' . OutputDefinition\Dao::TABLE_NAME . | |||
| $unitIds = $this->db->fetchAll('SELECT o_id, id, o_classId, ' . $this->db->quoteIdentifier('channel') . ' FROM ' . OutputDefinition\Dao::TABLE_NAME . | |||
There was a problem hiding this comment.
What will happen if we remove the o_prefixes here too?
Than there would be two id's right?
There was a problem hiding this comment.
AFAIK even for 11, it stays like that https://github.com/pimcore/output-data-config-toolkit/pull/70/files#diff-7fdd41fda0d42d2e2313b55101c6f5a0b16485a7f9f176896886c7636cc6d18cR40 but yes, it may lead to confusion.
There was a problem hiding this comment.
It is not very consistent then if we keep the o_prefixes here. @fashxp wdyt?
There was a problem hiding this comment.
The getter/setters were renamed to objectId, so i would vote for that.
It may be out of the scope of this PR and task, need to open a followup issue/PR for 5.x
mattamon
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #64
For MariaDB,
CHANNELis not a reserved keyword, but it is for MySQL, maybe should be considered as potential bug?