Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Fix Docs #92

Merged
merged 4 commits into from
May 8, 2023
Merged

[Task]: Fix Docs #92

merged 4 commits into from
May 8, 2023

Conversation

kingjia90
Copy link
Contributor

Currently installing in

output-data-config-toolkit/src/Tools/Installer.php

Lines 29 to 31 in f0e71da

if (!file_exists(PIMCORE_CUSTOM_CONFIGURATION_DIRECTORY . '/outputdataconfig')) {
$fileSystem->mkdir(PIMCORE_CUSTOM_CONFIGURATION_DIRECTORY . '/outputdataconfig', 0775);
copy(__DIR__ . '/../../install/config.php', PIMCORE_CUSTOM_CONFIGURATION_DIRECTORY . '/outputdataconfig/config.php');

but PIMCORE_CUSTOM_CONFIGURATION_DIRECTORY is https://github.com/pimcore/pimcore/blob/0af2664a34c85fcb6964a3fc67dbefde27715d26/lib/Bootstrap.php#L171

@kingjia90 kingjia90 added the Task label May 5, 2023
@kingjia90 kingjia90 added this to the v4.1.11 milestone May 5, 2023
@kingjia90 kingjia90 changed the title [Task]: Fixing Configuration location in docs [Task]: Fix Docs May 5, 2023
@mattamon mattamon merged commit dfbc7cb into 4.1 May 8, 2023
1 check passed
@mattamon mattamon deleted the fix-docs branch May 8, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattamon mattamon mattamon approved these changes

Assignees

@mattamon mattamon

Labels
Task
Projects
None yet
Milestone
v4.1.11
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kingjia90 @mattamon