Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend the etl process for the relevant product based es index #21

Merged

Conversation

agentS
Copy link
Contributor

@agentS agentS commented Jun 10, 2020

No description provided.

Copy link
Contributor Author

@agentS agentS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the configuration which should be part of the demo web shop from the bundle

class PersonalizationAdapterCustomerIdProviderImpl implements PersonalizationAdapterCustomerIdProvider {

public function getCustomerId(): int {
return Factory::getInstance()->getEnvironment()->getCurrentUserId();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This behaviour should be implemented in the Pimcore demo web shop.

@@ -18,9 +18,22 @@ services:
Pimcore\Bundle\PersonalizedSearchBundle\IndexAccessProvider\RelevantProductIndexAccessProvider: ~
Pimcore\Bundle\PersonalizedSearchBundle\IndexAccessProvider\IndexAccessProviderInterface: '@Pimcore\Bundle\PersonalizedSearchBundle\IndexAccessProvider\OrderIndexAccessProvider'

Pimcore\Bundle\PersonalizedSearchBundle\IndexAccessProvider\CustomerGroupIndexAccessProvider: ~
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be part of the demo web shop's service configuration. Please remove this.

Pimcore\Bundle\PersonalizedSearchBundle\ExtractTransformLoad\PurchaseHistoryProvider: ~
Pimcore\Bundle\PersonalizedSearchBundle\ExtractTransformLoad\PurchaseHistoryInterface: '@Pimcore\Bundle\PersonalizedSearchBundle\ExtractTransformLoad\PurchaseHistoryProvider'

Pimcore\Bundle\PersonalizedSearchBundle\ExtractTransformLoad\CustomerGroupProvider: ~
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be part of the demo web shop's service configuration. Please remove this.

class PersonalizationOrderManagerProviderImpl implements PersonalizationOrderManagerProvider {

function getOrderManager(): OrderManagerInterface {
return Factory::getInstance()->getOrderManager();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be part of the demo web shop's service configuration. Please remove this.

}

function getCustomerClassId(): string {
return \Pimcore\Model\DataObject\Customer::classId();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be part of the demo web shop's service configuration. Please remove this.

Copy link
Contributor Author

@agentS agentS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please get rid of the continue statement

src/ExtractTransformLoad/CustomerGroupProvider.php Outdated Show resolved Hide resolved
andreashorner and others added 3 commits June 10, 2020 12:38
…d-es-index' of github.com:pimcore/personalized-product-search into 69-extend-the-etl-process-for-the-relevant-product-based-es-index
@agentS agentS merged commit 9fbe0da into master Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants