-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extend the etl process for the relevant product based es index #21
extend the etl process for the relevant product based es index #21
Conversation
…dex' into 69-extend-the-etl-process-for-the-relevant-product-based-es-index
…mand for CustomerGroup-based option
…d-es-index' of github.com:pimcore/personalized-product-search into 69-extend-the-etl-process-for-the-relevant-product-based-es-index
…pprovider to assign customers to groups
…ch into 69-extend-the-etl-process-for-the-relevant-product-based-es-index
…d-es-index' of github.com:pimcore/personalized-product-search into 69-extend-the-etl-process-for-the-relevant-product-based-es-index
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the configuration which should be part of the demo web shop from the bundle
class PersonalizationAdapterCustomerIdProviderImpl implements PersonalizationAdapterCustomerIdProvider { | ||
|
||
public function getCustomerId(): int { | ||
return Factory::getInstance()->getEnvironment()->getCurrentUserId(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This behaviour should be implemented in the Pimcore demo web shop.
@@ -18,9 +18,22 @@ services: | |||
Pimcore\Bundle\PersonalizedSearchBundle\IndexAccessProvider\RelevantProductIndexAccessProvider: ~ | |||
Pimcore\Bundle\PersonalizedSearchBundle\IndexAccessProvider\IndexAccessProviderInterface: '@Pimcore\Bundle\PersonalizedSearchBundle\IndexAccessProvider\OrderIndexAccessProvider' | |||
|
|||
Pimcore\Bundle\PersonalizedSearchBundle\IndexAccessProvider\CustomerGroupIndexAccessProvider: ~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be part of the demo web shop's service configuration. Please remove this.
Pimcore\Bundle\PersonalizedSearchBundle\ExtractTransformLoad\PurchaseHistoryProvider: ~ | ||
Pimcore\Bundle\PersonalizedSearchBundle\ExtractTransformLoad\PurchaseHistoryInterface: '@Pimcore\Bundle\PersonalizedSearchBundle\ExtractTransformLoad\PurchaseHistoryProvider' | ||
|
||
Pimcore\Bundle\PersonalizedSearchBundle\ExtractTransformLoad\CustomerGroupProvider: ~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be part of the demo web shop's service configuration. Please remove this.
class PersonalizationOrderManagerProviderImpl implements PersonalizationOrderManagerProvider { | ||
|
||
function getOrderManager(): OrderManagerInterface { | ||
return Factory::getInstance()->getOrderManager(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be part of the demo web shop's service configuration. Please remove this.
} | ||
|
||
function getCustomerClassId(): string { | ||
return \Pimcore\Model\DataObject\Customer::classId(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be part of the demo web shop's service configuration. Please remove this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please get rid of the continue
statement
…d-es-index' of github.com:pimcore/personalized-product-search into 69-extend-the-etl-process-for-the-relevant-product-based-es-index
No description provided.