Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement]: Replace plugins with event listener #81

Merged
merged 3 commits into from
Jul 22, 2022

Conversation

robertSt7
Copy link
Contributor

@robertSt7 robertSt7 commented Jul 21, 2022

resolve #78

also see #90

@robertSt7 robertSt7 added this to the 1.5.0 milestone Jul 21, 2022
@CLAassistant
Copy link

CLAassistant commented Jul 21, 2022

CLA assistant check
All committers have signed the CLA.

@mcop1 mcop1 merged commit fb27a9a into 1.x Jul 22, 2022
@mcop1 mcop1 deleted the 78-improvement-replace-plugins-with-event-listener branch July 22, 2022 11:34
aryaantony92 pushed a commit that referenced this pull request Aug 16, 2022
* Improve: Replace plugin with event listener and fireEvent with dispatchEvent

* Improve: delete empty methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement]: Replace plugins with event listener
3 participants