You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The save() method on these classes actually accept arguments, but since it is by means of func_get_args() rather than method parameters it is not clear from the code overview given by docblock or editor inspections, e.g.
Nobody knows, unless reading every single line of code, that it is possible.
Improvement description
The
save()
method on these classes actually accept arguments, but since it is by means offunc_get_args()
rather than method parameters it is not clear from the code overview given by docblock or editor inspections, e.g.Nobody knows, unless reading every single line of code, that it is possible.
The code today:
pimcore/models/DataObject/Concrete.php
Lines 696 to 715 in 8746e89
But if re-written like this:
Or like this, which is more in line with what #13177 is doing:
I believe it would be much clearer and the need for calling
func_get_args()
would not be needed.The text was updated successfully, but these errors were encountered: