Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Remove Button control for DataObjects #15124

Closed
mcop1 opened this issue May 5, 2023 · 5 comments · Fixed by pimcore/admin-ui-classic-bundle#64 or #15131
Closed

[Task]: Remove Button control for DataObjects #15124

mcop1 opened this issue May 5, 2023 · 5 comments · Fixed by pimcore/admin-ui-classic-bundle#64 or #15131
Assignees
Labels
Milestone

Comments

@mcop1
Copy link
Contributor

mcop1 commented May 5, 2023

Improvement description

Remove Button control for DataObjects

Check if it is necessary to do the same for asset-metadata-class-definitions bundle.

Follow up to #15123

@aweichler
Copy link
Contributor

@mcop1 Why do you drop the Button? We are using it in serveral projects.

@lukmzig lukmzig linked a pull request May 8, 2023 that will close this issue
@NiklasBr
Copy link
Contributor

NiklasBr commented May 8, 2023

What was the motivation for this @Corepex?

@Corepex
Copy link
Collaborator

Corepex commented May 8, 2023

@aweichler and @NiklasBr the button component was a security issue in itself. We decided to remove the feature to prevent any security vulnerabilities in the future.

@NiklasBr
Copy link
Contributor

NiklasBr commented May 8, 2023

Do you have any documentation about it in the migration notes and recommendations for achieving the same functionality with another feature?

@fashxp
Copy link
Member

fashxp commented May 8, 2023

Create your custom layout component, see https://pimcore.com/docs/pimcore/current/Development_Documentation/Extending_Pimcore/Bundle_Developers_Guide/Adding_Object_%20Layout_types.html

@Corepex maybe we can add that to upgrade notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
6 participants