Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Incorrect update of Localizedfields in grid batch update operation (fallback to default locale) #17047

Open
root913 opened this issue May 14, 2024 · 0 comments
Labels

Comments

@root913
Copy link

root913 commented May 14, 2024

Pimcore version

v11.2.3

Steps to reproduce

Add localized field to grid and select not default locale. Batch update value.

Actual Behavior

This will update default locale value.

Expected Behavior

It should respect selected locale.
I'ts propably caused by change in models/DataObject/Traits/FieldDefinitionEnrichmentModelTrait.php file.
Method "getFieldDefinition" returns definition for Localizedfields and it brokes conditions that depend on null value of this method.
In this case condition in this file: https://github.com/pimcore/admin-ui-classic-bundle/blob/558c7c245208793ed67a413eca86810d75fcb325/src/Controller/Admin/DataObject/DataObjectHelperController.php#L1561 will return true and locale will not be passed on to setter.

@root913 root913 added the Bug label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant