Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Router] Remove logging of API Key of rest requests #4240

Closed
fashxp opened this issue Apr 15, 2019 · 2 comments · Fixed by #5600
Closed

[Router] Remove logging of API Key of rest requests #4240

fashxp opened this issue Apr 15, 2019 · 2 comments · Fixed by #5600
Assignees

Comments

@fashxp
Copy link
Member

fashxp commented Apr 15, 2019

router logs all requrest uris with something like that:

[2019-04-15 16:55:51] request.INFO: Matched route "document_17". {"route":"document_17","route_parameters":{"_locale":"en_GB","_controller":"AppBundle:Content:default","_route":"document_17"},"request_uri":"http://academy.pim.zone/en/special-functions/productmodel","method":"GET"} []

therefore also API keys if they are in request uri ...

we need to avoid that.

@fashxp
Copy link
Member Author

fashxp commented Nov 26, 2019

what is the state of that?

@brusch
Copy link
Member

brusch commented Jan 15, 2020

Since filtering the information is quite expensive in terms of performance, we should maybe think about providing the possibility to pass the API key via a HTTP header and make this as the recommended method. Everything else we leave as it is as the REST Services are deprecated anyway ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants