-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added reusable cla check #3
Conversation
Bumped CLA action version to latest one from action release repo
@herbertroth tested it here this is what needs to be added in source repo, not that cla_check branch in git url will be changed with tag version as soon this is merged and released
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we use the CLA_ACTION_ACCESS_TOKEN instead of PRIVATE_ACCESS_TOKEN?
And update doku here: https://pimcore.atlassian.net/wiki/spaces/PD/pages/2548006917/CLA+Checker
@herbertroth I thought so, but we need to stick to naming from cla checker will update docs afterwards - will create one migration doc |
So PERSONAL_ACCESS_TOKEN: ${{ secrets.CLA_ACTION_ACCESS_TOKEN }} would also work? or do i misunderstood the doku? |
Would probably, but I did not want to use different names for env variable and secret. |
@herbertroth ping for re-check dependent workflow should look like this
|
https://pimcore.atlassian.net/browse/SOLI-97
Added reusable CLA check workflow
Bumped CLA action version to latest one from action release repo
example usage of new CLA within dependent workflow
After this PR has been merged, new release will be created and dependent workflows will reference versioned one