Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Topics header #41

Closed
andyblarblar opened this issue Mar 31, 2023 · 0 comments
Closed

Add support for Topics header #41

andyblarblar opened this issue Mar 31, 2023 · 0 comments
Labels
enhancement

Comments

@andyblarblar
Copy link
Collaborator

Similar to the recent addition of the Urgency header in #39, we should add support for the very common Topic header.

Addition should be basically identical to the urgency header, just without the enum and with some sort of validation on the topic string.
depressed-pho added a commit to depressed-pho/rust-web-push that referenced this issue Nov 9, 2023
@depressed-pho
Add support for Topic header (pimeys#41)
d857986
depressed-pho added a commit to depressed-pho/rust-web-push that referenced this issue Nov 9, 2023
@depressed-pho
Add support for Topic header (pimeys#41)
7d528b5
@depressed-pho depressed-pho mentioned this issue Nov 9, 2023
Merged
depressed-pho added a commit to depressed-pho/rust-web-push that referenced this issue Nov 14, 2023
@depressed-pho
Add support for Topic header (pimeys#41)
959492f
andyblarblar pushed a commit that referenced this issue Nov 14, 2023
@depressed-pho
Add support for Topic header (#41) (#52)
836e018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andyblarblar