Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add base implementation of kernel smart account with ECDSA validator #42

Merged

Conversation

KONFeature
Copy link
Contributor

  • Add the signerToEcdsaKernelSmartAccount method to generate and use Kernel smart account that use an ecdsa validator.
  • Use a separated folder inside account, kernel/, for other validator implementation in the long term

Copy link

changeset-bot bot commented Nov 22, 2023

🦋 Changeset detected

Latest commit: f971a80

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
permissionless Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@plusminushalf
Copy link
Contributor

Hey! Thanks for contributing to permissionless.

This PR It looks like a great start and I have a few questions and comments:

  1. We don't need the whole ABI - src/accounts/kernel/abi/KernelAccountAbi.ts. We just need executeBatch, execute & initialize. If we can just include them and exclude the rest of abi it will save us on size.
  2. Is there a module support in the kernel? Do we need to enable them during initialization?
  3. Do kernel support execution during the setup/initialisation phase? This could be helpful for erc20 paymasters where you would like to approve USDC during initialisation so that paymaster already have access to approved USDC. This will allow paying for deployment of SCW with USDC.

@KONFeature
Copy link
Contributor Author

KONFeature commented Nov 23, 2023

Hey!

  1. ABI cleanup pushed
  2. Yeah they support module for the userOp validation phase, the activation of the ECDSA one is actually done during the createAccount phase (that's what we have in the getAccountInitCode(...) method, the initialisationData is here to enable the ECDSA module)
  3. Unfortunately no , they don't support that yet :/

For all the module management part, that why I created a separate kernel/ folder, I was thinking about an extension of the SmartAccount type specific to kernel, that support enabling / disabling validation module. But I haven't the time to do that right now aha

@plusminushalf plusminushalf merged commit 4707e52 into pimlicolabs:main Dec 7, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants