Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE8 Fix. #27

Closed
wants to merge 1 commit into from
Closed

IE8 Fix. #27

wants to merge 1 commit into from

Conversation

dorajistyle
Copy link

It was a problem that IE not recognize a function named 'apply'.
I read an article about console in IE.
http://tobyho.com/2012/07/27/taking-over-console-log/

Then I fixed the problem.
It tested on Firefox, Chrome, IE8, IE9, IE10.

It was a problem that IE not recognize a function named 'apply'.
I read an article about console in IE.
http://tobyho.com/2012/07/27/taking-over-console-log/

Then I fixed the problem.
It tested on Firefox, Chrome, IE8, IE9, IE10.
@pimterry pimterry closed this in e978f8b Sep 18, 2013
@pimterry
Copy link
Owner

This is great and I'm very thankful for the help! Unfortunately 😬 I found a better way.

I wasn't really a huge fan of the special case here, and I'm a bit worried that some other weird browsers or special usages are going to get funny with it, so instead I played around with the function calls a bit and came up a fix for with IE's messy apply method in e978f8b. I've tested this everywhere, and it seems to work fine, and keeps the script shorter and without any special cases or workarounds.

Sorry! I do feel a bit guilty for jumping in and taking over after you'd helped, but I wouldn't've worked it out without that article, so thanks for that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants