-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit and save a file that is not of the default NOTES_EXT #82
Comments
Hi @NumenHackerCracker good suggestion, thanks. I think this sounds like an easy & sensible fix: if the exact filename exists, Would you be interested in putting together a PR to fix that? I think the main place the extension is used is here: Lines 173 to 184 in 428946e
Lines 84 to 91 in 428946e
|
I've been doing some hacking on the script recently and I actually implemented this feature. I think all I had to do was change Looking at the code you posted, I'm wondering about this: if [ ! -f "$note_path" ]; then
note_path="$notes_dir/$note_path"
fi Is this there in case a user supplies an absolute path or something? it seems like the |
If you've got a fix for this issue in general, please do put in a PR, that'd be great.
Yes, I'm pretty sure that's why that's there. I don't remember the original reasoning for that (that line was last touched 5 years ago!) but it's a useful option to have, especially for composing |
My NOTES_EXT
variable is set to markdown, which is good, because that's what I take most of my notes in. However many of my "notes" are.c
or.py
files filled with comments on however the code in the file works. Whenever I open one of these files,notes
makes a new blank.md
file and names it exactly the same as the file I was trying to open instead of just opening the file. So, for example, if I were trying to openfile.c
,notes
will make a new file titledfile.c.md
. I want to be able to edit.md
notes along with.c
and.py
. Thanks!The text was updated successfully, but these errors were encountered: