Skip to content

Add support for explicit file extensions #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 9, 2021

Conversation

eshapard
Copy link
Contributor

Fixes #82
Closes #82

Checklist

  • I have made a change to this repository, be it functionality, testing, documentation, spelling, or grammar.
  • I updated my branch with the master branch.
  • I have added the necessary testing to prove my fix is effective/my feature works (or I did not modify functionality).
  • I have added necessary documentation about the functionality in an appropriate .md file.
  • I have appropriately commented any code I have modified

Short description of what this PR does:

Allows notes to accept explicit file extensions other than the default in note filenames.

Copy link
Collaborator

@primis primis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason here for limiting extensions to 4 characters?

@eshapard
Copy link
Contributor Author

eshapard commented Jun 9, 2021

@primis I figured there should be a limit. Otherwise, If you make a note about Mr.Bojangles, notes would assume that .Bojangles is the file extension.

@pimterry pimterry merged commit cd02a4b into pimterry:master Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit and save a file that is not of the default NOTES_EXT
3 participants