Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mopidy-AlarmClock package #270

Closed
DavisNT opened this issue Apr 11, 2015 · 9 comments
Closed

Add Mopidy-AlarmClock package #270

DavisNT opened this issue Apr 11, 2015 · 9 comments

Comments

@DavisNT
Copy link

DavisNT commented Apr 11, 2015

Package Mopidy-AlarmClock provides alarm clock. :bowtie: 馃敂

Currently the package can be manually set up as described in https://github.com/woutervanwijk/Pi-MusicBox/wiki/Setting-up-Alarm-Clock

Integration requires:

@DavisNT
Copy link
Author

DavisNT commented Apr 23, 2015

Is alarm clock feature welcome in Pi MusicBox?

@kingosticks
Copy link
Member

I'm really unfamiliar with the particular extension other than what has already been highlighted at mopidy/mopidy#1085 (comment). Don't think we've had any requests for the functionality either so it's not hugely interesting.

@DavisNT
Copy link
Author

DavisNT commented Apr 23, 2015

Users interested in this feature, please give your feedback here!

While this feature is not needed/welcomed, I will postpone work on integrating Mopidy-AlarmClock into default installation of Pi MusicBox. Meanwhile everybody can manually install it as described in: https://github.com/woutervanwijk/Pi-MusicBox/wiki/Setting-up-Alarm-Clock

@michaellunzer
Copy link

@DavisNT I'm very interested! I was able to add your solution as you suggested however it would be nice to see the alarm section completely integrated into @woutervanwijk's pimusicbox frontend (maybe as a new tab?)
馃憤 馃憤 馃憤 馃憤 馃憤 馃憤 馃憤 馃憤

They even have Font Awesome Icons to match the current theme!
http://fontawesome.io/icon/clock-o/

@DavisNT
Copy link
Author

DavisNT commented May 24, 2015

@kingosticks Is a Pull Request for MusicBox Webclient addling a link to AlarmClock (if it is installed) in main menu welcome?

@kingosticks
Copy link
Member

I guess it's ok to include a navigation link to it which we'll show only if it's installed (don't want to create another config option for this).

@michaellunzer
Copy link

I can't wait! Let me know if I can help in any way @DavisNT

@DavisNT
Copy link
Author

DavisNT commented May 30, 2015

I have created a Pull Request that adds link to Alarm Clock in Musicbox Webclient.
@michaellunzer thanks for the idea and Font Awesome icon!
@kingosticks could you please do the review/merge?

@jcass77
Copy link
Member

jcass77 commented Feb 22, 2016

#104 has been merged which addresses this issue.

@jcass77 jcass77 closed this as completed Feb 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants