add default alarm configuration option #1048
Conversation
|
Thanks and sorry for the 2.5 year delay in taking a look at this. I have rebased this on the latest master. I also think it's a good idea to have this in ikhal and while it's simple to add a default alarm for a new event, I'm not yet sure on how to convert the alarm if one changes the event from daytime to allday. Perhaps check if the alarm is equal to the default and change it then to the other default? |
geier
force-pushed
the
defaultalarm
branch
2 times, most recently
from
a066567
to
e0185a4
Compare
Good catch and I have no idea how that could be that wrong for so many years. Hopefully fixed. |
implemented that way. |
for more information, see https://pre-commit.ci
`default_event_duration` and `default_dayevent_duration` where mixed up. The default for `default_event_duration` was 1 day and it was used as the default lengths for new all-day events, now it is used for datetime events and the default is 1 hour. The opposite was true for `default_dayevent_duration`.
fixes #698
Not sure where I put it is the best place to, please comment on that.
Also: I think in the existing options "default_(day)event_duration" the terms "dayevent" and "event" are mixed up. I'd expect "dayevent" to refer to an day-long event and in contrast to that "event" an event of e.g. 1h duration, but the implementation is the other way round. My commit, nevertheless, uses this same (possibly reverse) meaning.