Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config with days and hightlight options #346

Merged
merged 1 commit into from
Mar 19, 2016

Conversation

spk
Copy link
Contributor

@spk spk commented Feb 20, 2016

Just add two nice options to sample config.
(debug did not work for me)
Cheers

@geier
Copy link
Member

geier commented Mar 17, 2016

Hi @spk! Thank you for your interest in khal and your PR!

You are totally right, debug doesn't do anything anymore.
I also like your other suggestions, but I'm not sure the format

# default 3
days = 30

is the best. I think something like

days = 30  # the default is 2

would be better. Could you update the PR (and please also add yourself to AUTHORS.txt) ?

@fpytloun
Copy link
Contributor

Nice, didn't know these options :-)

see pimutils#346 (comment)

Signed-off-by: Laurent Arnoud <laurent@spkdev.net>
Signed-off-by: Christian Geier <geier@lostpackets.de>
@spk
Copy link
Contributor Author

spk commented Mar 19, 2016

Hi @geier ! I've updated the PR with your suggestions.
Cheers !

untitaker added a commit that referenced this pull request Mar 19, 2016
Update config with days and hightlight options
@untitaker untitaker merged commit d84fe09 into pimutils:master Mar 19, 2016
@untitaker
Copy link
Member

🎊

@spk spk deleted the update-config-sample branch March 30, 2016 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants