New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config with days and hightlight options #346

Merged
merged 1 commit into from Mar 19, 2016

Conversation

Projects
None yet
4 participants
@spk
Contributor

spk commented Feb 20, 2016

Just add two nice options to sample config.
(debug did not work for me)
Cheers

@geier

This comment has been minimized.

Member

geier commented Mar 17, 2016

Hi @spk! Thank you for your interest in khal and your PR!

You are totally right, debug doesn't do anything anymore.
I also like your other suggestions, but I'm not sure the format

# default 3
days = 30

is the best. I think something like

days = 30  # the default is 2

would be better. Could you update the PR (and please also add yourself to AUTHORS.txt) ?

@fpytloun

This comment has been minimized.

Contributor

fpytloun commented Mar 18, 2016

Nice, didn't know these options :-)

Update config with days and hightlight options
see #346 (comment)

Signed-off-by: Laurent Arnoud <laurent@spkdev.net>
Signed-off-by: Christian Geier <geier@lostpackets.de>

@spk spk force-pushed the spk:update-config-sample branch from 4bfa41d to 21d0b3b Mar 19, 2016

@spk

This comment has been minimized.

Contributor

spk commented Mar 19, 2016

Hi @geier ! I've updated the PR with your suggestions.
Cheers !

untitaker added a commit that referenced this pull request Mar 19, 2016

Merge pull request #346 from spk/update-config-sample
Update config with days and hightlight options

@untitaker untitaker merged commit d84fe09 into pimutils:master Mar 19, 2016

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@untitaker

This comment has been minimized.

Member

untitaker commented Mar 19, 2016

🎊

@spk spk deleted the spk:update-config-sample branch Mar 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment