Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper logging #13

Closed
WhyNotHugo opened this issue Apr 17, 2016 · 7 comments
Closed

Proper logging #13

WhyNotHugo opened this issue Apr 17, 2016 · 7 comments

Comments

@WhyNotHugo
Copy link
Member

This issue was moved from the issue tracker at GitLab.


Todoman currently has no way of emitting warnings, and a possibility to turn those warnings on and off. Warnings will probably be required for reporting invalid items (the current behavior is basically to ignore those, because logging handlers are not set up properly)

I'd like to rip out some code from vdirsyncer and pallets/click#278, and make a third-party package on click-contrib to provide such things. I think I'll have to wait for Click 5.0 before implementing this though.

@untitaker
Copy link
Member

click-log has existed for a long time and yesterday I even documented it

@WhyNotHugo
Copy link
Member Author

Yes, I think click-log was a bit green last time I looked at this issue (and was thinking of it when moving it here).
I'll look at the doc and give it a try (and any feedback) when I have some free time.

Thanks!

@untitaker
Copy link
Member

API hasn't changed at all since a long time (mostly due to lacking feedback/userbase), and it's mostly just logging boilerplate code moved into a package.

@untitaker
Copy link
Member

click-log has now existed for more than a year and hasn't changed at all. According to https://libraries.io/pypi/click-log there are 8 repositories dependent on it, though none of them have a significant popularity. On the other hand vdirsyncer isn't listed.

@WhyNotHugo
Copy link
Member Author

Yes, it looks quite popular: https://github.com/search?utf8=%E2%9C%93&q=%22import+click_log%22&type=Code&ref=searchresults

Yup, I'm okay with using it.

@untitaker
Copy link
Member

It appears that GitHub's search is completely unusuable, this is also matched:

import click
log = ...

@WhyNotHugo
Copy link
Member Author

Yeah, lots of false positive, but if you scroll through them manually, you'll see there's lots of true positives too.

untitaker added a commit to untitaker/todoman that referenced this issue Feb 18, 2017
untitaker added a commit that referenced this issue Feb 20, 2017
* Add click-log

Fix #13

* Fixup

* Fixup

* Changelog for verbosity option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants