Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Important "done" tasks appear before not-important "to be done" tasks #27

Closed
jlbribeiro opened this issue Apr 22, 2016 · 2 comments
Closed

Comments

@jlbribeiro
Copy link
Contributor

Right now, when we do a todo list -a to list every task (including the done ones) they are sorted by priority first, then by status:

 1 [X]              Trivial task I've already done @personal (100%)
 2 [X]   2016-01-19 Another trivial task I took care of @personal (100%)
 3 [ ]              Trivial todo, waiting me to stop procrastinating @personal
 4 [ ]              Another trivial todo task I have to do @personal
 5 [X] ! 2016-04-09 This was important, but I've already done this @personal (100%)
 6 [X] ! 2016-04-05 This was important as well, but I done it yesterday  @personal (100%)
 7 [ ] !            This is important and I have to do this @personal
 8 [ ] !            This is important as well and is waiting for me @personal

IMHO it makes more sense to list them sorted by status, then by priority, so we get to see the tasks that still need action (both not important and important) closer to the bottom of the output, even though some of them are not as important as some done tasks.

 1 [X]              Trivial task I've already done @personal (100%)
 2 [X]   2016-01-19 Another trivial task I took care of @personal (100%)
 3 [X] ! 2016-04-09 This was important, but I've already done this @personal (100%)
 4 [X] ! 2016-04-05 This was important as well, but I done it yesterday  @personal (100%)
 5 [ ]              Trivial todo, waiting me to stop procrastinating @personal
 6 [ ]              Another trivial todo task I have to do @personal
 7 [ ] !            This is important and I have to do this @personal
 8 [ ] !            This is important as well and is waiting for me @personal

The fix for this is to simply swap the main.py#L40-41 lines, but since I believe this is a matter of preference I'm raising a "question" issue in order to see what you think.

If you feel this makes sense ping me and I'll submit the PR.

@WhyNotHugo
Copy link
Member

I don't generally want to alter the default sorting or change sorting orders constantly due to preference (I'd rather keep that stable), but this particular request makes a lot of sense (I don't really use -a so never realized this).

Feel free to submit a PR for this. 👍

@jlbribeiro
Copy link
Contributor Author

@hobarrera My thoughts exactly. I feel personal preference sorting settings should be left to the config file (or flags), but I'm suggesting this because I think those are better (i.e.: more intuitive) default settings.

I'll do the PR when I'm on my laptop 👍

WhyNotHugo pushed a commit that referenced this issue Apr 26, 2016
…dones

Fix #27: list "todo" tasks before "done" important tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants