Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement http storage in rust #730

Merged
merged 25 commits into from Jun 6, 2018
Merged

Implement http storage in rust #730

merged 25 commits into from Jun 6, 2018

Conversation

untitaker
Copy link
Member

@untitaker untitaker commented Apr 1, 2018

second attempt. First attempt crashed with corrupted memory when I tried to deploy it to my server

TODO:

  • write tests for real this time (this is not "trivial")
  • fix the bug
  • test on personal infra

* Port http storage to rust

* implement rest of parameters as far as possible

* stylefixes

* rustup

* fix invalid timestamp
@untitaker
Copy link
Member Author

So it turns out that the problem is somehow related to me instrumenting openssl 1.0 from both the embedded dylib and Python code. The problem goes away if I do one of:

  • upgrade to openssl 1.1
  • don't use the network code in Rust
  • don't use the network code in Python

not really sure what to do here. It seems this is blocked until I port the other storages to rust.

@untitaker untitaker merged commit 9324fa4 into master Jun 6, 2018
@untitaker untitaker deleted the rust-http branch June 6, 2018 12:16
@mathstuf
Copy link
Contributor

Note that this removed testing for radicale. Was that intended?

@untitaker
Copy link
Member Author

As part of this I got rid of a bunch of workarounds that only existed because of radicale

@mathstuf
Copy link
Contributor

Ah, OK. I assume that radicale is expected to work then?

@untitaker
Copy link
Member Author

I genuinely don't know, but I don't want to block a release on it

@mathstuf
Copy link
Contributor

OK, sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants