Upgrade Rust dependencies and fix build errors

[Mange]

I cannot compile this on Arch Linux anymore (#778) because of a version of OpenSSL not supported by the current OpenSSL-dependent crates.

OpenSSL was depended on by hyper, which was depended on by reqwest. The latest version of reqwest pulls in a newer hyper, which has a lot of breaking changes because they removed most of the type-safe HTTP parts.
(I hear this is temporary)

Anyway, I've ported all build errors to the newer version of reqwest. Most of the changes are pretty much copied-pasted everywhere; I did not try to extract any patterns or utility functions as I didn't want to make any assumptions on how you want to design this.

Let me know if you want me to do more abstractions or reduce the code size.

[yuceltoluyag]

@Mange #811 there is a similar situation, will you apply correction

[Mange]

I could take another look when I get some time on my hands.

[Mange]

@Mange #811 there is a similar situation, will you apply correction

I don't have any errors compiling the Rust stuff in this branch. The AUR build is not using my branch, though.

[Mange]

Now it's just Python errors as far as I can see in the failing builds.
I've rebased this on top of the latest master, so it should be safe to merge and deal with the unrelated errors in another branch.

[dilyanpalauzov]

With the above changes applied using Rust 1.42.0-dev I get these warnings:

running build
running build_py
copying vdirsyncer/version.py -> build/lib/vdirsyncer
   Compiling vdirsyncer-rustext v0.1.0 (/git/vdirsyncer/rust)
warning: trait objects without an explicit `dyn` are deprecated
  --> src/storage/dav/caldav.rs:69:47
   |
69 |     fn list<'a>(&'a mut self) -> Fallible<Box<Iterator<Item = (String, String)> + 'a>> {
   |                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Iterator<Item = (String, String)> + 'a`
   |
   = note: `#[warn(bare_trait_objects)]` on by default

warning: trait objects without an explicit `dyn` are deprecated
   --> src/storage/dav/caldav.rs:170:55
    |
170 |     fn discover(config: Self::Config) -> Fallible<Box<Iterator<Item = Self::Config>>> {
    |                                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Iterator<Item = Self::Config>`

warning: trait objects without an explicit `dyn` are deprecated
  --> src/storage/dav/carddav.rs:23:47
   |
23 |     fn list<'a>(&'a mut self) -> Fallible<Box<Iterator<Item = (String, String)> + 'a>> {
   |                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Iterator<Item = (String, String)> + 'a`

warning: trait objects without an explicit `dyn` are deprecated
  --> src/storage/dav/carddav.rs:66:55
   |
66 |     fn discover(config: Self::Config) -> Fallible<Box<Iterator<Item = Self::Config>>> {
   |                                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Iterator<Item = Self::Config>`

warning: trait objects without an explicit `dyn` are deprecated
   --> src/storage/dav/mod.rs:138:23
    |
138 |     ) -> Fallible<Box<Iterator<Item = (String, String)> + 'a>> {
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Iterator<Item = (String, String)> + 'a`

warning: trait objects without an explicit `dyn` are deprecated
   --> src/storage/dav/mod.rs:169:23
    |
169 |     ) -> Fallible<Box<Iterator<Item = (String, String)> + 'a>> {
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Iterator<Item = (String, String)> + 'a`

warning: trait objects without an explicit `dyn` are deprecated
   --> src/storage/dav/mod.rs:618:19
    |
618 |     ) -> *mut Box<Storage> {
    |                   ^^^^^^^ help: use `dyn`: `dyn Storage`

warning: trait objects without an explicit `dyn` are deprecated
   --> src/storage/dav/mod.rs:648:19
    |
648 |     ) -> *mut Box<Storage> {
    |                   ^^^^^^^ help: use `dyn`: `dyn Storage`

warning: trait objects without an explicit `dyn` are deprecated
  --> src/storage/exports.rs:16:68
   |
16 | pub unsafe extern "C" fn vdirsyncer_storage_free(storage: *mut Box<Storage>) {
   |                                                                    ^^^^^^^ help: use `dyn`: `dyn Storage`

warning: trait objects without an explicit `dyn` are deprecated
  --> src/storage/exports.rs:17:20
   |
17 |     let _: Box<Box<Storage>> = Box::from_raw(storage);
   |                    ^^^^^^^ help: use `dyn`: `dyn Storage`

warning: trait objects without an explicit `dyn` are deprecated
  --> src/storage/exports.rs:22:23
   |
22 |     storage: *mut Box<Storage>,
   |                       ^^^^^^^ help: use `dyn`: `dyn Storage`

warning: trait objects without an explicit `dyn` are deprecated
  --> src/storage/exports.rs:38:23
   |
38 |     storage: *mut Box<Storage>,
   |                       ^^^^^^^ help: use `dyn`: `dyn Storage`

warning: trait objects without an explicit `dyn` are deprecated
  --> src/storage/exports.rs:55:23
   |
55 |     storage: *mut Box<Storage>,
   |                       ^^^^^^^ help: use `dyn`: `dyn Storage`

warning: trait objects without an explicit `dyn` are deprecated
  --> src/storage/exports.rs:71:23
   |
71 |     storage: *mut Box<Storage>,
   |                       ^^^^^^^ help: use `dyn`: `dyn Storage`

warning: trait objects without an explicit `dyn` are deprecated
  --> src/storage/exports.rs:93:23
   |
93 |     storage: *mut Box<Storage>,
   |                       ^^^^^^^ help: use `dyn`: `dyn Storage`

warning: trait objects without an explicit `dyn` are deprecated
   --> src/storage/exports.rs:105:72
    |
105 | pub unsafe extern "C" fn vdirsyncer_storage_buffered(storage: *mut Box<Storage>) {
    |                                                                        ^^^^^^^ help: use `dyn`: `dyn Storage`

warning: trait objects without an explicit `dyn` are deprecated
   --> src/storage/exports.rs:111:23
    |
111 |     storage: *mut Box<Storage>,
    |                       ^^^^^^^ help: use `dyn`: `dyn Storage`

warning: trait objects without an explicit `dyn` are deprecated
   --> src/storage/exports.rs:119:23
    |
119 |     storage: *mut Box<Storage>,
    |                       ^^^^^^^ help: use `dyn`: `dyn Storage`

warning: trait objects without an explicit `dyn` are deprecated
   --> src/storage/exports.rs:132:23
    |
132 |     storage: *mut Box<Storage>,
    |                       ^^^^^^^ help: use `dyn`: `dyn Storage`

warning: trait objects without an explicit `dyn` are deprecated
   --> src/storage/exports.rs:143:23
    |
143 |     storage: *mut Box<Storage>,
    |                       ^^^^^^^ help: use `dyn`: `dyn Storage`

warning: trait objects without an explicit `dyn` are deprecated
   --> src/storage/exports.rs:150:19
    |
150 |     iterator: Box<Iterator<Item = (String, String)>>,
    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Iterator<Item = (String, String)>`

warning: trait objects without an explicit `dyn` are deprecated
  --> src/storage/filesystem.rs:91:19
   |
91 |     ) -> *mut Box<Storage> {
   |                   ^^^^^^^ help: use `dyn`: `dyn Storage`

warning: trait objects without an explicit `dyn` are deprecated
   --> src/storage/filesystem.rs:120:47
    |
120 |     fn list<'a>(&'a mut self) -> Fallible<Box<Iterator<Item = (String, String)> + 'a>> {
    |                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Iterator<Item = (String, String)> + 'a`

warning: trait objects without an explicit `dyn` are deprecated
   --> src/storage/filesystem.rs:248:55
    |
248 |     fn discover(config: Self::Config) -> Fallible<Box<Iterator<Item = Self::Config>>> {
    |                                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Iterator<Item = Self::Config>`

warning: trait objects without an explicit `dyn` are deprecated
   --> src/storage/http.rs:131:47
    |
131 |     fn list<'a>(&'a mut self) -> Fallible<Box<Iterator<Item = (String, String)> + 'a>> {
    |                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Iterator<Item = (String, String)> + 'a`

warning: trait objects without an explicit `dyn` are deprecated
   --> src/storage/http.rs:188:19
    |
188 |     ) -> *mut Box<Storage> {
    |                   ^^^^^^^ help: use `dyn`: `dyn Storage`

warning: trait objects without an explicit `dyn` are deprecated
  --> src/storage/singlefile.rs:83:90
   |
83 |     pub unsafe extern "C" fn vdirsyncer_init_singlefile(path: *const c_char) -> *mut Box<Storage> {
   |                                                                                          ^^^^^^^ help: use `dyn`: `dyn Storage`

warning: trait objects without an explicit `dyn` are deprecated
  --> src/storage/singlefile.rs:92:47
   |
92 |     fn list<'a>(&'a mut self) -> Fallible<Box<Iterator<Item = (String, String)> + 'a>> {
   |                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Iterator<Item = (String, String)> + 'a`

warning: trait objects without an explicit `dyn` are deprecated
   --> src/storage/singlefile.rs:225:55
    |
225 |     fn discover(config: Self::Config) -> Fallible<Box<Iterator<Item = Self::Config>>> {
    |                                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Iterator<Item = Self::Config>`

warning: trait objects without an explicit `dyn` are deprecated
  --> src/storage/mod.rs:32:55
   |
32 |     fn discover(config: Self::Config) -> Fallible<Box<Iterator<Item = Self::Config>>>;
   |                                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Iterator<Item = Self::Config>`

warning: trait objects without an explicit `dyn` are deprecated
  --> src/storage/mod.rs:48:47
   |
48 |     fn list<'a>(&'a mut self) -> Fallible<Box<Iterator<Item = (String, String)> + 'a>>;
   |                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Iterator<Item = (String, String)> + 'a`

warning: use of deprecated item 'failure::core::str::<impl str>::trim_right_matches': superseded by `trim_end_matches`
  --> src/storage/dav/mod.rs:91:37
   |
91 |             url: format!("{}/", url.trim_right_matches('/')),
   |                                     ^^^^^^^^^^^^^^^^^^ help: replace the use of the deprecated item: `trim_end_matches`
   |
   = note: `#[warn(deprecated)]` on by default

warning: unused boxed `std::iter::Iterator` trait object that must be used
   --> src/storage/http.rs:124:13
    |
124 |             self.list()?;
    |             ^^^^^^^^^^^^^
    |
    = note: `#[warn(unused_must_use)]` on by default
    = note: iterators are lazy and do nothing unless consumed

warning: unused boxed `std::iter::Iterator` trait object that must be used
  --> src/storage/singlefile.rs:61:13
   |
61 |             self.list()?;
   |             ^^^^^^^^^^^^^
   |
   = note: iterators are lazy and do nothing unless consumed

    Finished release [optimized] target(s) in 34.74s
copying dylib libvdirsyncer_rustext.so
generating cffi module for 'vdirsyncer._native'
already up-to-date
generating wrapper for 'vdirsyncer._native'
running build_ext
building 'vdirsyncer._native__lib' extension
gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -fPIC -I/usr/local/include/python3.6m -c build/temp.linux-x86_64-3.6/empty.c -o build/temp.linux-x86_64-3.6/build/temp.linux-x86_64-3.6/empty.o
gcc -pthread -shared build/temp.linux-x86_64-3.6/build/temp.linux-x86_64-3.6/empty.o -o /git/vdirsyncer/vdirsyncer/_native__lib.so

[WhyNotHugo]

LGTM, though I'm not the Rust expert here.

[WhyNotHugo]

Thanks for your contribution, but we've rolled back the rust portion of the project. See #790 for futher details.

Closing since it's no longer applicable.

[Mange]

Understandable. Thank you for picking this up. ❤️