Some code simplifications with the return statement #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WhyNotHugo
reviewed
Apr 7, 2021
| if subtype in weak: | ||
| return True | ||
| return False | ||
| return subtype in weak |
There was a problem hiding this comment.
This is a much welcome cleanup though.
| from requests.auth import HTTPDigestAuth | ||
| return HTTPDigestAuth(username, password) | ||
| elif auth == 'guess': | ||
| if auth == 'guess': |
There was a problem hiding this comment.
I don't really like this change.
It makes it far harder to figure out the flow. At a glance, I'd get the impression that this code run if auth == 'guess', but there's actually a return nested further above.
The elif makes it a bit more obvious that these are mutually exclusive code-paths.
There was a problem hiding this comment.
In all programming languages, writing else after return has no added value.
| @@ -181,7 +181,7 @@ def get_status_path(base_path, pair, collection=None, data_type=None): | |||
| def load_status(base_path, pair, collection=None, data_type=None): | |||
| path = get_status_path(base_path, pair, collection, data_type) | |||
| if not os.path.exists(path): | |||
| return None | |||
| return | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.