Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add runmailer #138

Merged
merged 3 commits into from Jan 13, 2021
Merged

Add runmailer #138

merged 3 commits into from Jan 13, 2021

Conversation

jaap3
Copy link
Contributor

@jaap3 jaap3 commented Jan 13, 2021

Add the runmailer management command that starts the send_loop function already available in mailer.engine.

Closes #136.

@coveralls
Copy link

coveralls commented Jan 13, 2021 •
edited

Coverage Status

Coverage decreased (-2.01%) to 86.461% when pulling 8e01a7b on leukeleu:add-runmailer into 2228d2b on pinax:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.9%) to 85.586% when pulling 8e01a7b on leukeleu:add-runmailer into 2228d2b on pinax:master.

spookylukey
spookylukey approved these changes Jan 13, 2021
View reviewed changes
Copy link
Contributor

@spookylukey spookylukey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This look brilliant, I saw one tiny typo but I'll fix that myself. Thanks for all the attention to detail - docs, release notes etc.

docs/usage.rst
* ``runmailer`` similar to ``send_mail``, but will keep running and checking the
database for new messages each ``MAILER_EMPTY_QUEUE_SLEEP`` (default: 30) seconds.
Can be used *instead* of ``send_mail`` to circumvent the maximum frequency
of once per minutes inherent to cron.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"once per minute"

@spookylukey spookylukey merged commit 35d0968 into pinax:master Jan 13, 2021
@jaap3 jaap3 deleted the add-runmailer branch November 4, 2021 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spookylukey spookylukey spookylukey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

What is the purpose of send_loop
3 participants
@jaap3 @coveralls @spookylukey