Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure Django < 3.2 uses BigAutoField #155

Merged
merged 1 commit into from
Nov 5, 2021
Merged

Make sure Django < 3.2 uses BigAutoField #155

merged 1 commit into from
Nov 5, 2021

Conversation

jaap3
Copy link
Contributor

@jaap3 jaap3 commented Nov 5, 2021

Follow up for #152 / #153.

@spookylukey
Copy link
Contributor

Hmm, this seems like something that lots of projects will come across, I wonder if there is a recommended standard solution?

@jaap3
Copy link
Contributor Author

jaap3 commented Nov 5, 2021

I've seen a lot of projects that set their AppConfig to always use AutoField. django-mailer however benefits from BigAutoField, especially when it's used in projects that send large volumes of mail. I haven't found any other way to do this in a backwards compatible way, except for the one I'm proposing here.

@spookylukey
Copy link
Contributor

OK, thanks for the info, this looks good.

@spookylukey spookylukey merged commit b4e92a6 into pinax:master Nov 5, 2021
@jaap3 jaap3 deleted the big-auto-field branch December 7, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jaap3 @spookylukey