Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added possibility to use MkdirLockFile as an alternative #44

Closed
wants to merge 1 commit into from

Conversation

psychok7
Copy link

I decided to create this PR because of #43 and in the end i realized that the problem was that i was using my Vagrant machine for development and it was not locking using the default FileLock from lockfile in my shared folder between the Guest and Host (maybe its related to hashicorp/vagrant#713 ).

in the aquire() function in the os.link() it was giving me OSError: [Errno 1] Operation not permitted

I then realized that lockfile also allows MkdirLockFile that provides a mkdir(2)() system call as the basic lock mechanism and it is even used on Windows systems.

Basically this PR allows the user to choose if he wants to use FileLock or MkdirLockFile where FileLock continues being the default.

@paltman
Copy link
Member

paltman commented Aug 14, 2015

@spookylukey we have a Slack setup for Pinax now with a channel dedicated to django-mailer. Want to join? http://slack.pinaxproject.com

@psychok7
Copy link
Author

@spookylukey does this seem reasonable to you??

@spookylukey
Copy link
Contributor

Actually, it seems overkill to have a setting for this.

If you find you need to change the setting, you've already wasted a lot of time debugging, probably. It should Just Work all the time, or have an explicit error if it can't work.

@ossanna16
Copy link
Contributor

Any further discussion on this? Can this PR be closed?

psychok7 referenced this pull request in Ubiwhere/pinax-notifications Feb 11, 2016
@psychok7 psychok7 closed this Feb 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants