added possibility to use MkdirLockFile as an alternative #44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to create this PR because of #43 and in the end i realized that the problem was that i was using my
Vagrant
machine for development and it was not locking using the defaultFileLock
from lockfile in my shared folder between the Guest and Host (maybe its related to hashicorp/vagrant#713 ).in the
aquire()
function in the os.link() it was giving meOSError: [Errno 1] Operation not permitted
I then realized that lockfile also allows
MkdirLockFile
that provides amkdir(2)() system call as the basic lock mechanism
and it is even used on Windows systems.Basically this PR allows the user to choose if he wants to use
FileLock
orMkdirLockFile
whereFileLock
continues being the default.