Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up send error handling; fix stalled send queue. #78

Closed
wants to merge 1 commit into from
Closed

Clean up send error handling; fix stalled send queue. #78

wants to merge 1 commit into from

Commits on Dec 10, 2016

  1. Clean up send error handling; fix stalled send queue. 

    [NOT FOR MERGE yet: see "TODO" comments for discussion]

In engine.send_all:

* Handle transient connection issues by logging failure
  and cleanly exiting send_all. (Previously, crashed
  without logging.)
* Handle all other smtplib.SMTPException by deferring
  message. (Previously, behavior differed between
  Python 2 and 3.)
* Handle all other exceptions by logging error with new
  RESULT_ERROR status and deleting message from send
  queue. (Previously, crashed without logging, leaving
  possibly-unsendable message blocking send queue.)

**Potentially-breaking change:** If you are using a
MAILER_EMAIL_BACKEND other than the default
SMTP EmailBackend, errors from that backend *may*
be handled differently now.

Addresses pinax#73. (And additional discussion there.)
    @medmunds
    medmunds committed Dec 10, 2016
    Configuration menu
    Copy the full SHA
    65fbb75 View commit details
    Browse the repository at this point in the history