Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

django 2.0 compat #94

Merged
merged 3 commits into from Jan 3, 2018
Merged

Conversation

davidszotten
Copy link
Contributor

@davidszotten davidszotten commented Dec 30, 2017

django < 2.0 is fine inserting bytestrings into a textfield, but as of 2.0 there is a (py3) isinstance(str) -> str(value) which for b'foo' becomes "b'foo'"

@coveralls
Copy link

coveralls commented Dec 30, 2017

Coverage Status

Coverage remained the same at 86.229% when pulling 8386098 on davidszotten:django2.0-compat into 9e49f34 on pinax:master.

@coveralls
Copy link

coveralls commented Dec 30, 2017

Coverage Status

Coverage remained the same at 86.229% when pulling a20ed2d on davidszotten:django2.0-compat into 9e49f34 on pinax:master.

@coveralls
Copy link

coveralls commented Dec 30, 2017

Coverage Status

Coverage remained the same at 86.229% when pulling ee6fc00 on davidszotten:django2.0-compat into 9e49f34 on pinax:master.

@davidszotten
Copy link
Contributor Author

ping @spookylukey

@spookylukey spookylukey merged commit 38a056c into pinax:master Jan 3, 2018
@spookylukey
Copy link
Contributor

Thanks!

@davidszotten
Copy link
Contributor Author

thank you! any chance of a release? anything i can do to make that easier (e.g. do you like/dislike changes.txt + version bumps in the same pr)?

@spookylukey
Copy link
Contributor

An entry in CHANGES.txt would help. Normally I follow RELEASE.rst but it looks like I forgot to add the new section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants