Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve resource module test coverage #23

Merged
merged 1 commit into from Jul 26, 2016

Conversation

ethanmcc
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Jul 21, 2016

Coverage Status

Coverage increased (+1.06%) to 63.588% when pulling 4554080 on ethanmcc:improve-resource-test-coverage into 34a8775 on pinax:master.

def test_getitem_should_use_type(self):
self.assertEqual(self.identifier['type'], sentinel.api_type)

def test_getitem_should_support_type(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ethanmcc Should this method be named test_getitem_should_use_id()?

@ethanmcc ethanmcc force-pushed the improve-resource-test-coverage branch from 4554080 to 0c411d1 Compare July 24, 2016 15:43
@ethanmcc
Copy link
Contributor Author

@grahamu updated the test name

@coveralls
Copy link

coveralls commented Jul 24, 2016

Coverage Status

Coverage increased (+1.06%) to 63.588% when pulling 0c411d1 on ethanmcc:improve-resource-test-coverage into 34a8775 on pinax:master.

@grahamu grahamu merged commit b18609c into pinax:master Jul 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants