Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix migration for unique slugs #86

Open
paltman opened this issue Jul 10, 2016 · 4 comments
Open

Fix migration for unique slugs #86

paltman opened this issue Jul 10, 2016 · 4 comments

Comments

@paltman
Copy link
Member

paltman commented Jul 10, 2016

the PINAX_BLOG_SLUG_UNIQUE setting when set to True, causes a migration to be generated after install. the migrations that ship with pinax-blog were created with the default settings which is False.

perhaps the migration should be edited to be dynamic based on that setting. that doesn't handle the case where you might want to switch after you have installed but could handle the case where you know what you want from the start.

@jtauber
Copy link
Member

jtauber commented Jul 21, 2016

@paltman do you think this needs to be done for 16.07?

@paltman
Copy link
Member Author

paltman commented Jul 21, 2016

@jtauber ideally but i'm not sure of how to fix it

@jtauber jtauber modified the milestone: post-16.07 Jul 23, 2016
@jtauber jtauber modified the milestones: 16.10, post-16.07 Sep 6, 2016
@paltman
Copy link
Member Author

paltman commented Sep 6, 2016

@brosner any ideas?

@KatherineMichel
Copy link
Member

Is this still relevant? Perhaps can be closed at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants