Rework to Support Latest API #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives you the ability to run a single test for isolation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a few backwards incompatible changes that made supporting the latest Stripe API very difficult. When combined looking at all the new features now available since when this library first started out years ago (as django-stripe-payments), I decided to refactor the code base into a service layer supported by proxy models to give us more modularity and setting us up for easier testing and maintenance.
The templates no longer ship with
pinax-stripe. They will be shipping in the next release of pinax-theme-bootstrap, however. For templates of this nature to be useful, design decisions need to be made and reliance on frameworks such as Bootstrap will be invariably made. It seems more appropriate to ship the templates I'm going to produce for this with our bootstrap theme as I'm going to use that framework as well as our block structure.It is important to point out that the views shipping with this are intentionally pretty lean. I've cut out all AJAX and therefore any prescribed reliance on
eldarion-ajax. There are some mixins you might find useful and being class based views, you could get along customizing things a lot by subclassing them. I think it would be more useful forpinax-stripeto focus first on building up a solid set of mixing and base views that project sites could customize. Eventually I think we could have some really polished out of the box views for different scenarios.NOTE
This does not give us 100% coverage of what the Stripe API supports. There is a lot in the change log with regards to added features that still need to be added to
pinax-stripe, however, it should solve the bigger blockers in using the latest API, naming multiple subscriptions per user and field changes onChargeobjects.