Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add metadata to subscription #536

Open
wants to merge 3 commits into
base: original
Choose a base branch
from
Open

add metadata to subscription #536

wants to merge 3 commits into from

Conversation

turly221
Copy link

What's this PR do?

add metadata to subscription

Any background context you want to provide?

In my system, the billing is for the business entity, not the user. I want to track the business subscription usage.

What ticket or issue # does this fix?

Closes #[issue number]

Definition of Done (check if considered and/or addressed):

  • Are all backwards incompatible changes documented in this PR?
  • Have all new dependencies been documented in this PR?
  • Has the appropriate documentation been updated (if applicable)?
  • Have you written tests to prove this change works (if applicable)?

@codecov
Copy link

codecov bot commented Jan 23, 2018

Codecov Report

Merging #536 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #536      +/-   ##
=========================================
+ Coverage    99.4%   99.4%   +<.01%     
=========================================
  Files          33      33              
  Lines        1838    1842       +4     
  Branches      168     169       +1     
=========================================
+ Hits         1827    1831       +4     
  Misses          5       5              
  Partials        6       6
Flag Coverage Δ
#py27dj110 99.07% <100%> (ø) ⬆️
#py27dj111 99.07% <100%> (ø) ⬆️
#py27dj18 99.34% <100%> (ø) ⬆️
#py34dj110 99.07% <100%> (ø) ⬆️
#py34dj111 99.07% <100%> (ø) ⬆️
#py34dj18 99.34% <100%> (ø) ⬆️
#py34dj20 99.07% <100%> (ø) ⬆️
#py35dj110 99.07% <100%> (ø) ⬆️
#py35dj111 99.07% <100%> (ø) ⬆️
#py35dj18 99.34% <100%> (ø) ⬆️
#py35dj20 99.07% <100%> (ø) ⬆️
#py36dj111 99.07% <100%> (ø) ⬆️
#py36dj20 99.07% <100%> (ø) ⬆️
#py36dj20psql 99.07% <100%> (ø) ⬆️
Impacted Files Coverage Δ
pinax/stripe/models.py 100% <100%> (ø) ⬆️
pinax/stripe/actions/subscriptions.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fafa715...4f6e4e2. Read the comment docs.

@blueyed
Copy link
Contributor

blueyed commented Jan 23, 2018

LGTM, although I would prefer to have it in a more generic way, since it is supported with all (updatable) models - but this is an existing problem already.
Ref: https://stripe.com/docs/api#metadata

@turly221
Copy link
Author

turly221 commented Jan 23, 2018

Just did a quick check for below sections

CORE RESOURCES, PAYMENT METHODS and SUBSCRIPTIONS:

  • source, payout, refund, token, BankAccount, plan, Card, Coupon, Discount, Invoice, lines, invoiceitem, subscription, subscription_item have metadata
  • events, file_upload don't have it

To implement a generic way of this, we need to define what are the Updatable Stripe objects

@sfdye
Copy link

sfdye commented Jan 24, 2018

+1 for this

@blueyed
Copy link
Contributor

blueyed commented May 8, 2018

Charges also have metadata (not handled currently by pinax-stripe).

@paltman paltman added this to the Next milestone Oct 9, 2018
@paltman paltman removed this from the Next milestone Nov 25, 2021
@paltman paltman added the Original The original full pinax-stripe version with cached models and actions service layer label Nov 26, 2021
@paltman paltman changed the base branch from master to original November 26, 2021 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Original The original full pinax-stripe version with cached models and actions service layer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants