Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unexisting name from plan data for Synchronizes a plan action #625

Open
wants to merge 11 commits into
base: original
Choose a base branch
from

Conversation

andressspinetti
Copy link

@andressspinetti andressspinetti commented Dec 20, 2018

What's this PR do?

Remove name from dict used for synchronize a plan.

Any background context you want to provide?

Plan object does not come with name property and makes the plan signals to fail. More information in Stripe Docs: https://stripe.com/docs/api/plans#plan_object

What ticket or issue # does this fix?

Closes #[issue number]

Definition of Done (check if considered and/or addressed):

  • Are all backwards incompatible changes documented in this PR?
  • Have all new dependencies been documented in this PR?
  • Has the appropriate documentation been updated (if applicable)?
  • Have you written tests to prove this change works (if applicable)?

@codecov
Copy link

codecov bot commented Dec 20, 2018

Codecov Report

Merging #625 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #625      +/-   ##
==========================================
+ Coverage   99.21%   99.21%   +<.01%     
==========================================
  Files          33       33              
  Lines        1911     1913       +2     
  Branches      175      176       +1     
==========================================
+ Hits         1896     1898       +2     
  Misses          7        7              
  Partials        8        8
Flag Coverage Δ
#py27dj110 98.9% <100%> (ø) ⬆️
#py27dj111 98.9% <100%> (ø) ⬆️
#py27dj18 99.16% <100%> (ø) ⬆️
#py34dj110 98.9% <100%> (ø) ⬆️
#py34dj111 98.9% <100%> (ø) ⬆️
#py34dj18 99.16% <100%> (ø) ⬆️
#py34dj20 98.9% <100%> (ø) ⬆️
#py35dj110 98.9% <100%> (ø) ⬆️
#py35dj111 98.9% <100%> (ø) ⬆️
#py35dj18 99.16% <100%> (ø) ⬆️
#py35dj20 98.9% <100%> (ø) ⬆️
#py36dj111 98.9% <100%> (ø) ⬆️
#py36dj20 98.9% <100%> (ø) ⬆️
#py36dj20psql 98.9% <100%> (ø) ⬆️
Impacted Files Coverage Δ
pinax/stripe/actions/plans.py 100% <100%> (ø) ⬆️
pinax/stripe/models.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0005850...35d88f0. Read the comment docs.

@andressspinetti andressspinetti changed the title Remove unexisting name from plan data for Synchronizes a plan action WIP: Remove unexisting name from plan data for Synchronizes a plan action Dec 20, 2018
@andressspinetti andressspinetti changed the title WIP: Remove unexisting name from plan data for Synchronizes a plan action Remove unexisting name from plan data for Synchronizes a plan action Dec 20, 2018
@paltman paltman changed the base branch from master to 4.x November 26, 2021 15:55
@paltman paltman added the Original The original full pinax-stripe version with cached models and actions service layer label Nov 26, 2021
@paltman paltman changed the base branch from 4.x to original November 26, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Original The original full pinax-stripe version with cached models and actions service layer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants