Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix urlpatterns to no longer use deprecated patterns() syntax #20

Merged
merged 1 commit into from
Oct 20, 2017

Conversation

adamfeldman
Copy link
Contributor

django.conf.urls.patterns was removed in Django 1.10, after being deprecated in Django 1.8. Please see https://docs.djangoproject.com/en/1.8/ref/urls/#django.conf.urls.patterns

@coveralls
Copy link

coveralls commented Sep 26, 2016

Coverage Status

Coverage remained the same at 37.762% when pulling ee7a49f on adamfeldman:patch-1 into 06c65bf on pinax:master.

@adamfeldman
Copy link
Contributor Author

The build failed only on Python 3.2

From the travis-ci log: "UserWarning: Support for Python 3.0-3.2 has been dropped. Future versions will fail here."

@hugovk
Copy link

hugovk commented Oct 20, 2017

I think it's safe to drop it entirely, it's been EOL since 2016-02-27 and most of the most-downloaded packages have also dropped it.

https://en.wikipedia.org/wiki/CPython#Version_history
https://hugovk.github.io/drop-python/3.2/

@paltman
Copy link
Member

paltman commented Oct 20, 2017

agreed. i need to take a pass and update this this app over all. Hopefully that'll happen soon.

@paltman paltman merged commit a3bf28a into pinax:master Oct 20, 2017
@paltman
Copy link
Member

paltman commented Oct 20, 2017

Thanks @adamfeldman! Sorry it's been over a year. So embarrassing. Only excuse is that it slipped through the cracks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants