Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow void-return queries with arguments #132

Merged
merged 3 commits into from
May 4, 2019
Merged

Allow void-return queries with arguments #132

merged 3 commits into from
May 4, 2019

Conversation

vitusortner
Copy link
Collaborator

@vitusortner vitusortner commented May 4, 2019 •
edited
Loading

With this PR, no-return queries (Future<void>) can be used with arguments passed as parameters of the query method.

@vitusortner vitusortner added the feature Request and implementation of a feature (release drafter) label May 4, 2019
@vitusortner vitusortner changed the title Allow no return queries with parameters Allow no return queries with arguments May 4, 2019
@vitusortner vitusortner changed the title Allow no return queries with arguments Allow no-return queries with arguments May 4, 2019
@vitusortner vitusortner changed the title Allow no-return queries with arguments Allow void-return queries with arguments May 4, 2019
@vitusortner vitusortner mentioned this pull request May 4, 2019
Closed
@codecov
Copy link

codecov bot commented May 4, 2019 •
edited
Loading

Codecov Report

Merging #132 into develop will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #132      +/-   ##
===========================================
+ Coverage    72.54%   72.63%   +0.08%     
===========================================
  Files           48       48              
  Lines         1326     1330       +4     
===========================================
+ Hits           962      966       +4     
  Misses         364      364
Impacted Files Coverage Δ
floor/lib/src/adapter/query_adapter.dart 97.56% <100%> (ø) ⬆️
...loor_generator/lib/writer/query_method_writer.dart 97.95% <100%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1316f16...971094d. Read the comment docs.

@vitusortner vitusortner merged commit b2b3126 into develop May 4, 2019
@delete-merged-branch delete-merged-branch bot deleted the no-return-query-with-parameters branch May 4, 2019 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature Request and implementation of a feature (release drafter)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@vitusortner