Add support for embedded objects #328

hsul4n · 2020-05-12T01:42:33Z

Here's an implementation for @Embedded annotation with test and example.

Closing #9

hsul4n · 2020-05-12T02:22:40Z

Is there any issue with testing nullable boolean

vitusortner · 2020-05-12T07:27:15Z

Thanks for your contribution! I'll look into it as soon as possible.

hsul4n · 2020-05-13T01:19:35Z

@vitusortner sorry for unnecessary commits, checkout the new clarified commits.

hsul4n · 2020-05-14T11:25:31Z

Rebasing develop branch to get the latest commit #327

vitusortner

I've left some questions. Thanks for your initiative in starting this non-trivial task!

floor_generator/lib/processor/queryable_processor.dart

floor_generator/lib/processor/embedded_processor.dart

floor_generator/lib/value_object/embedded.dart

floor_generator/lib/value_object/entity.dart

hsul4n · 2020-05-16T21:01:07Z

Thanks, @vitusortner for catching gaps, I'll try to follow the suggestions and also provide better testing.

hsul4n · 2020-05-27T18:38:11Z

I've left some questions. Thanks for your initiative in starting this non-trivial task!

Resolved with 292cfb4, will update CHANGELOG.md, README.md & version after approving changes.

- Use prefix in field_processor for prefixing embedded columns. - Use StringBuffer instead of List<String> for building the constructor on queryable_processor for more clarity . - Add embedded_processor_test for testing embeddings.

…bedded objects

codecov · 2020-05-28T13:00:21Z

Codecov Report

Merging #328 into develop will decrease coverage by 0.25%.
The diff coverage is 82.90%.

@@             Coverage Diff             @@
##           develop     #328      +/-   ##
===========================================
- Coverage    81.51%   81.25%   -0.26%     
===========================================
  Files           59       63       +4     
  Lines         1509     1590      +81     
===========================================
+ Hits          1230     1292      +62     
- Misses         279      298      +19

Flag	Coverage Δ
#floor	`81.25% <82.90%> (-0.26%)`	⬇️
#floor_generator	`80.82% <82.90%> (-0.27%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
floor_generator/lib/value_object/entity.dart	`77.33% <51.51%> (-18.67%)`	⬇️
floor_generator/lib/value_object/embedded.dart	`69.23% <69.23%> (ø)`
...nerator/lib/extension/field_element_extension.dart	`100.00% <100.00%> (ø)`
...or_generator/lib/processor/embedded_processor.dart	`100.00% <100.00%> (ø)`
...loor_generator/lib/processor/entity_processor.dart	`75.23% <100.00%> (+0.23%)`	⬆️
floor_generator/lib/processor/field_processor.dart	`89.65% <100.00%> (ø)`
...r_generator/lib/processor/queryable_processor.dart	`98.07% <100.00%> (+0.51%)`	⬆️
floor_generator/lib/processor/view_processor.dart	`95.83% <100.00%> (+0.18%)`	⬆️
floor_generator/lib/value_object/field.dart	`66.66% <100.00%> (+1.44%)`	⬆️
floor_generator/lib/value_object/fieldable.dart	`100.00% <100.00%> (ø)`
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3efee4d...f9ac68c. Read the comment docs.

- Add boolean extension for parsing nullable fields. - Add Fieldable abstract class for both (Field, Embedded). - Passing null in constructor when field is ignore. - Fix nullable boolean field test case. - Some improvement and code enhancement.

proninyaroslav · 2020-07-07T17:19:57Z

@hsul4n Will this feature reach the final point?

hsul4n · 2020-07-08T03:31:16Z

@hsul4n Will this feature reach the final point?

Absolutely, but for now theres a major change on api due to #318 & #361, also embedded objects depend on relations annotations to reach final points.

proninyaroslav · 2020-07-08T08:01:04Z

@hsul4n
Thank you. Yeah, I really look forward to the support of type converters, as well as the embedded objects. Without them, I will to make very ugly code.

proninyaroslav · 2020-10-17T18:35:13Z

@hsul4n
During this time, a lot of work has been done, including the appearance of type converters. It would be great to have also embedded objects 👍

amkuchta · 2020-10-27T18:37:39Z

@hsul4n @vitusortner I'm really looking forward to this feature - Floor is exactly what I was looking for in an ORM package, and this is the missing piece that I need. Thank you guys for all of the hard work!

Is there a rough idea of when it will be completed?

jonasN5 · 2020-12-07T10:01:40Z

Any news on embedded & relation features?
ATM I need 3 subsequent queries with post processing to achieve what could be done in a single query :(

amkuchta · 2021-03-22T10:55:49Z

@hsul4n @vitusortner any updates on this? It's been about 6 months since I last asked, and it seems to have died... Looks like no changes since 30 July 2020?

marcosmko · 2021-03-25T23:23:12Z

any updates?
maybe I could finish this, if needed!

amkuchta · 2021-03-26T19:56:57Z

@marcosmko I'd be willing to pitch in, too. I'll need to poke through the code to get an idea if how it all works

vitusortner · 2021-04-05T14:01:32Z

@marcosmko, @amkuchta anything I can help you with? This PR has a bunch of conflicts by now but it might still help to get an idea of how to implement the feature. Thanks for your support 🙏

marcosmko · 2021-04-18T22:08:18Z

Hello @vitusortner, @amkuchta and @hsul4n, I synced this branch and created #538, but I still need to fix some things that got broken.

hsul4n force-pushed the feat_embedded branch from ce3fe29 to 233dec0 Compare May 13, 2020 01:09

hsul4n force-pushed the feat_embedded branch from 233dec0 to 234ccd4 Compare May 13, 2020 01:31

mqus linked an issue May 13, 2020 that may be closed by this pull request

Support embedded objects #9

Open

hsul4n force-pushed the feat_embedded branch from 234ccd4 to aa90fb6 Compare May 14, 2020 11:20

hsul4n mentioned this pull request May 14, 2020

Support embedded objects #9

Open

vitusortner reviewed May 15, 2020

View reviewed changes

hsul4n changed the title ~~Add support for embedded~~ Add support for embedded objects May 27, 2020

hsul4n force-pushed the feat_embedded branch from aa90fb6 to 292cfb4 Compare May 27, 2020 18:26

hsul4n requested a review from vitusortner May 27, 2020 23:28

hsul4n added 4 commits May 28, 2020 14:05

Add @Embedded annotation

bba6d2f

- Add embedded value_object and processor.

61f871d

- Use prefix in field_processor for prefixing embedded columns. - Use StringBuffer instead of List<String> for building the constructor on queryable_processor for more clarity . - Add embedded_processor_test for testing embeddings.

Implement embedded objects in example

9a501ad

Update floor version to 0.13.0 & update README.md for implementing em…

9848bbd

…bedded objects

hsul4n force-pushed the feat_embedded branch from 292cfb4 to 0980dfc Compare May 28, 2020 12:57

hsul4n force-pushed the feat_embedded branch from 0980dfc to 446187b Compare May 28, 2020 13:22

hsul4n force-pushed the feat_embedded branch from 446187b to e5fa8d5 Compare May 28, 2020 13:29

mqus mentioned this pull request May 29, 2020

Joint Table not Mapper in Object Class #347

Closed

mqus mentioned this pull request Jul 12, 2020

Entity with field another entity #369

Closed

Merge branch 'develop' into feat_embedded

f9ac68c

marcosmko mentioned this pull request Apr 18, 2021

Add support for embedded objects #538

Closed

marcosmko mentioned this pull request May 19, 2021

Add support for embedded objects #565

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for embedded objects #328

Add support for embedded objects #328

hsul4n commented May 12, 2020 •

edited

hsul4n commented May 12, 2020

vitusortner commented May 12, 2020

hsul4n commented May 13, 2020 •

edited

hsul4n commented May 14, 2020

vitusortner left a comment

hsul4n commented May 16, 2020

hsul4n commented May 27, 2020 •

edited

codecov bot commented May 28, 2020 •

edited

proninyaroslav commented Jul 7, 2020

hsul4n commented Jul 8, 2020

proninyaroslav commented Jul 8, 2020

proninyaroslav commented Oct 17, 2020

amkuchta commented Oct 27, 2020

jonasN5 commented Dec 7, 2020

amkuchta commented Mar 22, 2021

marcosmko commented Mar 25, 2021

amkuchta commented Mar 26, 2021

vitusortner commented Apr 5, 2021

marcosmko commented Apr 18, 2021

Add support for embedded objects #328

Are you sure you want to change the base?

Add support for embedded objects #328

Conversation

hsul4n commented May 12, 2020 • edited

hsul4n commented May 12, 2020

vitusortner commented May 12, 2020

hsul4n commented May 13, 2020 • edited

hsul4n commented May 14, 2020

vitusortner left a comment

Choose a reason for hiding this comment

hsul4n commented May 16, 2020

hsul4n commented May 27, 2020 • edited

codecov bot commented May 28, 2020 • edited

Codecov Report

proninyaroslav commented Jul 7, 2020

hsul4n commented Jul 8, 2020

proninyaroslav commented Jul 8, 2020

proninyaroslav commented Oct 17, 2020

amkuchta commented Oct 27, 2020

jonasN5 commented Dec 7, 2020

amkuchta commented Mar 22, 2021

marcosmko commented Mar 25, 2021

amkuchta commented Mar 26, 2021

vitusortner commented Apr 5, 2021

marcosmko commented Apr 18, 2021

hsul4n commented May 12, 2020 •

edited

hsul4n commented May 13, 2020 •

edited

hsul4n commented May 27, 2020 •

edited

codecov bot commented May 28, 2020 •

edited