Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improving hello world example & fix Readme dead links #62

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

adrienluitot
Copy link

This is a little improvement of the Hello World example.
I replaced the call of the helloworld() by a printf(), I think it's more intuitive.

I also added a prototype of the bl_uart_init() function to make things clearer and explained a little more its parameters.

I finally took the liberty to change the baud rate, because with some test I figured out that if the baud rate is too high, some bugged characters are printed. I chose 230 400 because it's a multiple of the standard 9600 and seems to me to be a good compromise, it is fast enough and has no bugged character.

This is a little improvement of the Hello World example.
Update and fix docs' links
@adrienluitot adrienluitot changed the title improving hello world example improving hello world example & fix Readme dead links Jan 31, 2021
@gamelaster
Copy link
Member

Hey, there is merge conflict.

Also, The baudrate works good on most of platforms.

@adrienluitot
Copy link
Author

Hey, yep indeed @tchebb fixed the problem directly. ^^

For the baudrate I had less bugs with a lower one, but I can edit this if you want.

@adrienluitot
Copy link
Author

I've just checked the conflict, I wanted to revert but I saw that the number of pages was not updated. But also when I made the PR the DS version 1.6 was not out, so I'm outdated on it. I don't know if you prefer that I update the readme for the number of page, or if you prefer that I revert and I let you do this ?

@uis246
Copy link
Contributor

uis246 commented Feb 7, 2021

Most common baudrates are 9600 and 115200

@pine64 pine64 deleted a comment from IllOrion Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants