Skip to content

Commit

Permalink
Removed not important error message about invalid DFU signature
Browse files Browse the repository at this point in the history
  • Loading branch information
gamelaster committed Feb 10, 2021
1 parent 7c15637 commit 8dd88f5
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions mainwindow.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,9 @@ void MainWindow::Flash()
this->ConsolePrint(data);
});
connect(workerThread, &FlashingThread::consoleErrorData, this, [this](QString data) {
if (data.contains("Invalid DFU suffix signature", Qt::CaseInsensitive)) {
return;
}
this->ConsolePrintError(data);
});
connect(workerThread, &FlashingThread::successed, this, [this, deleteFirmware, firmwarePath]() {
Expand Down

4 comments on commit 8dd88f5

@tormodvolden
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you not add a standard DFU suffix to your firmware files instead?

@gamelaster
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tormodvolden I'm not author of the firmwares, this is task for Ralim/IronOS

@tormodvolden
Copy link
Contributor

@tormodvolden tormodvolden commented on 8dd88f5 Sep 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'll try to bark up that tree instead. [https://github.com/Ralim/IronOS/issues/1050]

BTW, I came here searching for pinecil, which has recently showed up in a number of dfu-util bug report. I was very glad to discover what looks like a GUI shell for dfu-util, with an open license. I suppose this can be used for any DFU device by changing the hard-coded VID/PID? Just let me know if you have any issues or suggestions for dfu-util. I have been thinking of adding something to help these kind of "shells", for instance better machine-parsable output, also for flash progress, but only if someone will actually use it.

I have one wish for your tool: That it keeps all dfu-util output (and the executed command line) in a way that users can copy-paste or save it if diagnostics are needed.

@gamelaster
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this can be basically a GUI for dfu-util, even it's very simple. And thanks for opening issue for IronOS :)

Please sign in to comment.