Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing highlighting in TypeScript #3

Closed
Tomburgs opened this issue Dec 12, 2020 · 4 comments
Closed

Missing highlighting in TypeScript #3

Tomburgs opened this issue Dec 12, 2020 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@Tomburgs
Copy link

Hey, I love the color scheme, but there are some issues with it when working with TypeScript / TypeScript React.

Here's some of the issues I've encountered:

  • Keywords such as const and typeof don't get highlighted (default foreground color).
  • Function keyword is highlighted in the same color as the name of the function.
  • Function return type doesn't always get highlighted (JSX.Element in the screenshot).

Here's screenshots for comparison

Default
default

Spaceduck
spaceduck

It seems like the typescriptVariable / typescriptType / etc Vim values need to be linked to the correct definitions, however, I'm not sure how this works with the Estilo workflow.

I'm also concerned about the color on comments or HTML brackets, as they are quite dark and a bit difficult to read / see.
Perhaps there's something that can be done about this?

@pineapplegiant pineapplegiant added the bug Something isn't working label Dec 12, 2020
@pineapplegiant pineapplegiant self-assigned this Dec 12, 2020
@pineapplegiant
Copy link
Owner

Oof yeah that is ugly.

Good find and these screenshots are great! I was able to recreate the error. I'll try to get this done in the next couple days as I need to standardize where colors go more consistently. Just curious, are you using a specific syntax plugin by any chance? Thanks again.

@Tomburgs
Copy link
Author

Just curious, are you using a specific syntax plugin by any chance? Thanks again.

I do have vim-polyglot plugin installed which uses yats.vim, however it's now the default TypeScript highlighting in Vim & NeoVim, so there shouldn't be any issues without it.

@pineapplegiant
Copy link
Owner

@Tomburgs Just updated the branch with another commit hopefully that fixes the Typescript issue. (I think there's too much pink now), but go ahead and give that a try. I just updated the README with all of the locations of the colors too.

@pineapplegiant
Copy link
Owner

pineapplegiant commented Dec 16, 2020

Screen Shot 2020-12-15 at 5 03 02 PM

Might change the pink braces in the JSX. But I'm gonna close this for now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants