A few bug fixes following OpenAI client update #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had a call for openai.Models to check the OpenAI connection, but the client has changed
- Only verify OpenAI connection if OpenAI is used in configuration - Verify configuration before starting the server, to give a clear error message - Don't error out on the main `canopy` command (always show the intro \ help message)
Did not update to use the new OpenAI client
It was missing a test, appraently
You look away one sec and Co-Pilot is havocing your error messages...
Meant to add it before and forgot
miararoy
reviewed
Nov 16, 2023
|
|
||
| def _load_kb_config(config_file: Optional[str]) -> Dict[str, Any]: | ||
| config = _read_config_file(config_file) | ||
| if not config: |
There was a problem hiding this comment.
Nope, config can return empty ({}) from _read_config_file().
| @@ -132,6 +136,22 @@ def _load_kb_config(config_file: Optional[str]) -> Dict[str, Any]: | |||
| return kb_config | |||
|
|
|||
|
|
|||
| def _validate_chat_engine(config_file: Optional[str]): | |||
| config = _read_config_file(config_file) | |||
| Tokenizer.initialize() | |||
There was a problem hiding this comment.
We should have a "with tokenizer..."
A nice feature
There was a problem hiding this comment.
Yeah, thought about it.
Doesn't worth the effort right now...
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
After OpenAI client was updated (#171), a few problems arose:
canopyCLI command (without subcommand) always errored outOpenAILLM.avilable_modelswas brokenSolution
There was a minor bug in the CLI that still used the old
openaisyntax.But there was a deeper issue: Since we'll be adding support for more LLMs soon, it doesn't make sense that the CLI verifies the OpenAI connection at the top level. Changes:
OpenAIcomponent is in the configuration.canopy start, before running the server itself. This allows the CLI to catch the actual error, and present it to the user in a controlled manner (instead of the error being raise inside theUVicornprocess itself, which we can't catch).OpenAILLM.availble_modelsand add a UTType of Change
Test Plan
OpenAILLM