Cohere integration #203
Merged
Cohere integration #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acatav
reviewed
Dec 7, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
So that users could use Canopy with Cohere embedding
Added cohere to pyproject
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
7 tasks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Should be `^`, not hard coded single version.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Exciting PR, thanks for putting it together! |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
The `Install Dependencies` GH action runs `poetry install` twice - first just installing the dependnecies, using cahced ones if available, then again for installing the actual `canopy-sdk` project. The second call to `poetry install` wasn't asked to install `--all-extras`, so it **removed** what it deemed were "redundant" dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Continuation from #194
Solution
Added required tests
Type of Change
Test Plan
Added tests