Add instruction query generator #226
Conversation
|
|
||
| class CondensedQueryGenerator(QueryGenerator): | ||
| _DEFAULT_COMPONENTS = { | ||
| "llm": AnyscaleLLM, |
There was a problem hiding this comment.
Not sure if it not make more sense to use OpenAI also here as default. It seems more consistent for me, especially when we add more LLMs
There was a problem hiding this comment.
I also think so but @igiloh-pinecone had a comment on this. I agree that our default should be OpenAI
| pass | ||
|
|
||
|
|
||
| class CondensedQueryGenerator(QueryGenerator): |
There was a problem hiding this comment.
I'm not sure condensed describes well enough what this class is doing. How about InstructionQueryGenerator ? I think instruction prompting is the most common terminology for this type of prompt and parsing
There was a problem hiding this comment.
@igiloh-pinecone what do you think about the name?
There was a problem hiding this comment.
I tend to agree with @acatav , the name Instruction or even Prompt is more common.
The "condensed" naming is a term that LLamaIndex invented, and I haven't seen it used otherwise.
izellevy
changed the title
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Problem
Currently, we only support LLMs that have function calling functionality for query generation. We need to support LLMs that do not have this functionality.
Solution
Added a new query generator that is able to generate a question based on the chat history without using function calling
Type of Change
Test Plan
Describe specific steps for validating this change.